[Mesa-dev] [PATCH:mesa] glsl_compiler: Remove unused extra argument to printf in usage_fail

Alan Coopersmith alan.coopersmith at oracle.com
Mon May 25 13:31:43 PDT 2015


Flagged by Oracle's parfait static analyzer:

Error: Format string argument mismatch (CWE 628)
   In call to printf with format string "usage: %s [options] <file.vert | file.geom | file.frag>\n\nPossible options are:\n"
      Too many arguments for format string (got more than 1 arguments)
        at line 285 of src/glsl/main.cpp in function 'usage_fail'.

Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
---
 src/glsl/main.cpp |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/glsl/main.cpp b/src/glsl/main.cpp
index ccac839..4b39c9e 100644
--- a/src/glsl/main.cpp
+++ b/src/glsl/main.cpp
@@ -281,9 +281,9 @@ usage_fail(const char *name)
    const char *header =
       "usage: %s [options] <file.vert | file.geom | file.frag>\n"
       "\n"
       "Possible options are:\n";
-   printf(header, name, name);
+   printf(header, name);
    for (const struct option *o = compiler_opts; o->name != 0; ++o) {
       printf("    --%s\n", o->name);
    }
    exit(EXIT_FAILURE);
-- 
1.7.9.2



More information about the mesa-dev mailing list