[Mesa-dev] [PATCH] docs: add information about reviewing patches

Brian Paul brianp at vmware.com
Tue May 26 10:41:34 PDT 2015


---
 docs/devinfo.html | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/docs/devinfo.html b/docs/devinfo.html
index f5113b0..eb3aba1 100644
--- a/docs/devinfo.html
+++ b/docs/devinfo.html
@@ -266,6 +266,31 @@ re-sending the whole series). Using --in-reply-to makes
 it harder for reviewers to accidentally review old patches.
 </p>
 
+<h3>Reviewing Patches</h3>
+
+<p>
+When you've reviewed a patch on the mailing list, please be unambiguous
+about your review.  That is, state either
+<pre>
+    Reviewed-by: Joe Hacker <jhacker at foo.com>
+</pre>
+or
+<pre>
+    Acked-by: Joe Hacker <jhacker at foo.com>
+</pre>
+Rather than saying just "LGTM" or "Seems OK".
+</p>
+
+<p>
+If small changes are suggested, it's OK to say something like:
+<pre>
+   With the above fixes, Reviewed-by: Joe Hacker <jhacker at foo.com>
+</pre>
+which tells the patch author that the patch can be committed, as long
+as the issues are resolved first.
+</p>
+
+
 <h3>Marking a commit as a candidate for a stable branch</h3>
 
 <p>
-- 
1.9.1



More information about the mesa-dev mailing list