[Mesa-dev] [PATCH] glapi: Avoid argparse type argument for API XML input files.

[Dylan Baker]

On Tue, May 26, 2015 at 02:05:41PM -0400, Ilia Mirkin wrote:
> On Tue, May 26, 2015 at 2:06 PM, Dylan Baker <baker.dylan.c at gmail.com> wrote:
> > On Tue, May 26, 2015 at 11:15:36AM +0100, Jose Fonseca wrote:
> >> argparse type is a nice type saver for simple data types, but it doesn't
> >> look a good fit for the input XML file:
> >>
> >> - Certain implementations of argparse (particularly python 2.7.3's)
> >>   invoke the type constructor for the default argument even when an
> >>   option is passed in the command line.  Causing `No such file or
> >>   directory: 'gl_API.xml'` when the current dir is not
> >>   src/mapi/glapi/gen.
> >>
> > The fix is fine, I'm not complaining about the changes.
> >
> > However,
> >
> > I'm running 'scons' against python 2.7.3 and it's building fine with
> > your patch reverted. Is there something I'm missing about the way that
> > the scons build works? The documentation says that just 'scons' is all
> > that is necessary, is that not the case?
> 
> Do an out-of-tree build where gl_API.xml isn't in the current directory.
> 

out-of-tree builds were not brought up in the discussion, I have been
working under the assumption of in-tree-builds.

I'm also not sure at all how that's relavent, since the scons build
doesn't pass absolute paths, so falling back to the default or passing
'-f' should come up with the same result.

Or did I completely misunderstand what you're saying?

> >
> > Dylan
> >
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/mesa-dev
> >
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150526/4563c8e1/attachment.sig>