[Mesa-dev] [v4 PATCH 05/10] mesa: helper function for scissor box of gl_framebuffer

Kenneth Graunke kenneth at whitecape.org
Wed May 27 10:05:40 PDT 2015

On Wednesday, May 27, 2015 01:17:21 PM Rogovin, Kevin wrote:
> Hi,
> > 44 instances of a leading + in mesa/main compared to 78 trailing ones.
> > Huh, I was going to say that it's really uncommon to do this in mesa, but that may not be supported by fact.
> Considering there is a formatting issue below, I can change it to trailing. I don’t care.
> >> +      if (ymax < bbox[3]) {
> >> +        bbox[3] = ymax;
> >indent looks messed up here.
> Sighs, because it is. I missed that line, and I have missed that one since v2. I really wish I had a script to check the indenting. Sighs.

Out of curiosity, what editor are you using?  Usually setting the
indentation rules in your editor takes care of most of these problems.

If you're using vim, this will give you the correct settings for Mesa:

if has("autocmd")
    au BufNewFile,BufRead */mesa/* set expandtab tabstop=8 softtabstop=3 shiftwidth=3

We have a .dir-locals.el file that should provide the correct settings
for Emacs.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150527/c81c5be5/attachment.sig>

More information about the mesa-dev mailing list