[Mesa-dev] [PATCH v3 1/6] gallium: expose a debug message callback settable by context owner

Ilia Mirkin imirkin at alum.mit.edu
Mon Nov 2 12:14:17 PST 2015


On Mon, Nov 2, 2015 at 3:07 PM, Marek Olšák <maraeo at gmail.com> wrote:
>> diff --git a/src/gallium/include/pipe/p_state.h b/src/gallium/include/pipe/p_state.h
>> index 4bf8d46..2843bb6 100644
>> --- a/src/gallium/include/pipe/p_state.h
>> +++ b/src/gallium/include/pipe/p_state.h
>> @@ -684,6 +684,35 @@ struct pipe_compute_state
>>     unsigned req_input_mem; /**< Required size of the INPUT resource. */
>>  };
>>
>> +/**
>> + * Structure that contains a callback for debug messages from the driver back
>> + * to the state tracker.
>> + */
>> +struct pipe_debug_info
>> +{
>
> I would prefer it if this structure were called pipe_debug_callback,
> which is what it really is.

To confirm -- just change the struct, leave the set_debug_info call alone?

Thanks,

  -ilia


More information about the mesa-dev mailing list