[Mesa-dev] [PATCH 05/24] i965: Reorganize brw_reg fields.

[Emil Velikov]

On 3 November 2015 at 17:27, Matt Turner <mattst88 at gmail.com> wrote:
> On Tue, Nov 3, 2015 at 2:38 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> On 3 November 2015 at 00:29, Matt Turner <mattst88 at gmail.com> wrote:
>>> Put fields that are meaningless with an immediate in the same storage
>>> with the immediate.
>> There is something funky here. Should it be
>>
>> "Put fields that are meaningless _without_ an immediate in the same storage
>> _as_ the immediate..."
>
>
> I think what I said (though "with" -> "as" does sound better). To
> elaborate: some things like writemask, swizzle, vstride, width,
> hstride are only meaningful when the register is not an immediate --
> that is, they're mutually exclusive.
>
> So, use the same storage as the immediate to store those fields.
Dough... you're right I've spilled my marbles there.

Sorry about that.
Emil