[Mesa-dev] [PATCH 18/24] i965: Combine register file field.

[Emil Velikov]

On 3 November 2015 at 18:10, Matt Turner <mattst88 at gmail.com> wrote:
> On Tue, Nov 3, 2015 at 8:07 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> On 3 November 2015 at 00:29, Matt Turner <mattst88 at gmail.com> wrote:
>>
>>> index 6eeafd5..3d2b051 100644
>>> --- a/src/mesa/drivers/dri/i965/brw_fs.cpp
>>> +++ b/src/mesa/drivers/dri/i965/brw_fs.cpp
>>> @@ -423,7 +423,6 @@ fs_reg::fs_reg(uint8_t vf0, uint8_t vf1, uint8_t vf2, uint8_t vf3)
>>>  fs_reg::fs_reg(struct brw_reg reg) :
>>>     backend_reg(reg)
>>>  {
>>> -   this->file = (enum register_file)reg.file;
>> Should we fold the remaining this->file = foo into the backend_reg() ctors ?
>
> Not necessary. The only remaining file field after this commit is in
> brw_reg. So the backend_reg(reg) constructor is already doing that.
I might be missing a patch but I think that the default
fs/src/dst_reg() ctors still have it ?
Either way it's not a show stopper.

-Emil