[Mesa-dev] [PATCH 2/8] nir: Properly invalidate metadata in nir_lower_global_vars_to_local().

Jason Ekstrand jason at jlekstrand.net
Tue Nov 3 13:31:56 PST 2015


On Tue, Nov 3, 2015 at 12:31 AM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/glsl/nir/nir_lower_global_vars_to_local.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/src/glsl/nir/nir_lower_global_vars_to_local.c b/src/glsl/nir/nir_lower_global_vars_to_local.c
> index fab2366..9fa64ed 100644
> --- a/src/glsl/nir/nir_lower_global_vars_to_local.c
> +++ b/src/glsl/nir/nir_lower_global_vars_to_local.c
> @@ -100,6 +100,8 @@ nir_lower_global_vars_to_local(nir_shader *shader)
>           exec_node_remove(&var->node);
>           var->data.mode = nir_var_local;
>           exec_list_push_tail(&impl->locals, &var->node);
> +         nir_metadata_preserve(impl, nir_metadata_block_index |
> +                                     nir_metadata_dominance);

This doesn't invalidate live_variables (which should be renamed live_ssa_values)
--Jason

>           progress = true;
>        }
>     }
> --
> 2.6.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list