[Mesa-dev] [PATCH] i965: check inst->predicate when clearing flag_live at dead code eliminate

[Alejandro Piñeiro]

Gentle ping. FWIW, this patch is a really small one.

PS: I already pinged Matt about this, but probably Friday evening is not
the best time for reminders ;)

On 22/10/15 22:25, Alejandro Piñeiro wrote:
> Detected by Matt Turner while reviewing commit
> a59359ecd22154cc2b3f88bb8c599f21af8a3934
> ---
>  src/mesa/drivers/dri/i965/brw_fs_dead_code_eliminate.cpp   | 2 +-
>  src/mesa/drivers/dri/i965/brw_vec4_dead_code_eliminate.cpp | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_fs_dead_code_eliminate.cpp b/src/mesa/drivers/dri/i965/brw_fs_dead_code_eliminate.cpp
> index 4b5548a..1eaf147 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs_dead_code_eliminate.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs_dead_code_eliminate.cpp
> @@ -105,7 +105,7 @@ fs_visitor::dead_code_eliminate()
>              }
>           }
>  
> -         if (inst->writes_flag()) {
> +         if (inst->writes_flag() && !inst->predicate) {
>              BITSET_CLEAR(flag_live, inst->flag_subreg);
>           }
>  
> diff --git a/src/mesa/drivers/dri/i965/brw_vec4_dead_code_eliminate.cpp b/src/mesa/drivers/dri/i965/brw_vec4_dead_code_eliminate.cpp
> index 284e0a8..e8a51d6 100644
> --- a/src/mesa/drivers/dri/i965/brw_vec4_dead_code_eliminate.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_vec4_dead_code_eliminate.cpp
> @@ -145,7 +145,7 @@ vec4_visitor::dead_code_eliminate()
>              }
>           }
>  
> -         if (inst->writes_flag()) {
> +         if (inst->writes_flag() && !inst->predicate) {
>              for (unsigned c = 0; c < 4; c++)
>                 BITSET_CLEAR(flag_live, c);
>           }

-- 
Alejandro Piñeiro (apinheiro at igalia.com)