[Mesa-dev] [PATCH 1/2] i965: Don't include missing components in the fast clear color

[Ben Widawsky]

On Wed, Nov 04, 2015 at 06:11:09PM +0100, Neil Roberts wrote:
> Neil Roberts <neil at linux.intel.com> writes:
> 
> > Normally this doesn't matter because fast color clears are only
> > available on Gen7+ and for that hardware we also always set the
> > texture swizzle to force the missing components to zero or one.
> 
> Looking at it a bit more I think this part is wrong and it doesn't
> actually set the texture swizzle in for this case. It is actually a
> general problem even without the blorp. I can demonstrate it with this
> simpler test which I've posted to the Piglit mailing list:
> 
> http://patchwork.freedesktop.org/patch/63678/
> 
> Apart from the commit message I think the patch is still sound and it
> does fix the test case.
> 
> I tried to make a version that is based on top of Ben's skl-fast-clear
> branch but it doesn't seem to work on SKL. I am currently looking into
> this.
> 

It seems reasonable to me, but since you touch the same code I touch in fast
clears, and since I always screw up rebases, any chance I could persuade you to
wait until I land fast clears?