[Mesa-dev] [PATCH 08/24] i965: Remove fixed_hw_reg field from backend_reg.

Emil Velikov emil.l.velikov at gmail.com
Thu Nov 5 08:21:57 PST 2015


On 3 November 2015 at 16:04, Emil Velikov <emil.l.velikov at gmail.com> wrote:

>> @@ -1596,8 +1586,7 @@ vec4_visitor::lower_attributes_to_hw_regs(const int *attribute_map,
>>          reg.type = inst->dst.type;
>>          reg.writemask = inst->dst.writemask;
>>
>> -        inst->dst.file = HW_REG;
>> -        inst->dst.fixed_hw_reg = reg;
>> +         inst->dst = reg;
> Same concern, as in fs_visitor::assign_curb_setup. Past the struct
> brw_reg, dst_reg will be uninitialized. Or is the
> dst_reg::dst_reg(struct brw_reg reg) ctor going to kick in here ?
>
For posterity:

Yes. dst_reg::dst_reg(struct brw_reg reg) kicks in, thus the remaining
variables are correctly initialised.

-Emil


More information about the mesa-dev mailing list