[Mesa-dev] [PATCH 1/2] main: Don't restrict several KHR_debug enum to desktop GL

Emil Velikov emil.l.velikov at gmail.com
Thu Nov 5 12:01:22 PST 2015


Hi Boyan,

On 4 November 2015 at 15:25, Boyan Ding <boyan.j.ding at gmail.com> wrote:
> In preparation for supporting GL_KHR_debug in OpenGL ES
>
> Signed-off-by: Boyan Ding <boyan.j.ding at gmail.com>
> ---
>  src/mesa/main/enable.c    | 5 +----
>  src/mesa/main/getstring.c | 5 +----
>  2 files changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/src/mesa/main/enable.c b/src/mesa/main/enable.c
> index 42f6799..33000fd 100644
> --- a/src/mesa/main/enable.c
> +++ b/src/mesa/main/enable.c
> @@ -369,10 +369,7 @@ _mesa_set_enable(struct gl_context *ctx, GLenum cap, GLboolean state)
>           break;
>        case GL_DEBUG_OUTPUT:
>        case GL_DEBUG_OUTPUT_SYNCHRONOUS_ARB:
> -         if (!_mesa_is_desktop_gl(ctx))
> -            goto invalid_enum_error;
> -         else
> -            _mesa_set_debug_state_int(ctx, cap, state);
> +         _mesa_set_debug_state_int(ctx, cap, state);
There is another similar hunk in _mesa_IsEnabled. With that the patch is
Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>

I will send a "append KHR to function names when in ES context" patch
and with that we can enable the extension.

Thanks for bringing this up !
Emil


More information about the mesa-dev mailing list