[Mesa-dev] [PATCH 07/24] i965: Use immediate storage in inherited brw_reg.

[Kenneth Graunke]

On Monday, November 02, 2015 04:29:17 PM Matt Turner wrote:
[snip]
> @@ -362,8 +362,10 @@ src_reg::equals(const src_reg &r) const
>  	   abs == r.abs &&
>  	   swizzle == r.swizzle &&
>  	   !reladdr && !r.reladdr &&
> -	   memcmp(&fixed_hw_reg, &r.fixed_hw_reg,
> -		  sizeof(fixed_hw_reg)) == 0);
> +           (file != HW_REG ||
> +            memcmp(&fixed_hw_reg, &r.fixed_hw_reg,
> +                   sizeof(fixed_hw_reg)) == 0) &&
> +           (file != IMM || d == r.d));
>  }

This seems different...previously we always memcmp'd the fixed_hw_reg.
I think your code is what we *should* do, but would it make sense to
have a patch before this which changes it to:

(file != HW_REG || file != IMM || memcmp(...))

Then this would seem like a reasonable translation.

--Ken
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20151105/38f69103/attachment.sig>