[Mesa-dev] [PATCH 4/4] st/va: add support for RGBX and BGRX in VPP

[Julien Isorce]

On 5 November 2015 at 16:27, Emil Velikov <emil.l.velikov at gmail.com> wrote:

> Hi Julien,
>
> On 5 November 2015 at 08:24, Julien Isorce <julien.isorce at gmail.com>
> wrote:
> > Before it was only possible to convert a NV12 surface to
> > RGBA or BGRA. This patch uses the same post processing
> > function, "handleVAProcPipelineParameterBufferType", but
> > add definitions for RGBX and BGRX.
> >
> > This patch also makes vlVaQuerySurfaceAttributes more generic.
> >
> > Signed-off-by: Julien Isorce <j.isorce at samsung.com>
> > ---
> >  src/gallium/auxiliary/vl/vl_video_buffer.c | 18 +++++++++++++++
> >  src/gallium/state_trackers/va/picture.c    |  5 +++--
> >  src/gallium/state_trackers/va/surface.c    | 36
> +++++++++++++++++-------------
> >  src/gallium/state_trackers/va/va_private.h |  1 +
> >  4 files changed, 42 insertions(+), 18 deletions(-)
> >
> As the diffstat suggests - two different areas, thus this should be
> different patches.
>
> Ok I'll split it.


>
> > @@ -314,7 +319,9 @@ vlVaQuerySurfaceAttributes(VADriverContextP ctx,
> VAConfigID config,
> >     vlVaDriver *drv;
> >     VASurfaceAttrib *attribs;
> >     struct pipe_screen *pscreen;
> > -   int i;
> > +   int i, j;
> > +
> > +   STATIC_ASSERT(ARRAY_SIZE(vpp_surface_formats) <=
> VL_VA_MAX_IMAGE_FORMATS);
> >
> Nice, thank you !
>

no pb :)


>
>
> > --- a/src/gallium/state_trackers/va/va_private.h
> > +++ b/src/gallium/state_trackers/va/va_private.h
> > @@ -49,6 +49,7 @@
> >  #define VL_VA_PSCREEN(ctx) (VL_VA_DRIVER(ctx)->vscreen->pscreen)
> >
> >  #define VL_VA_MAX_IMAGE_FORMATS 9
> > +#define VL_VA_MAX_SURFACE_ATTRIBUTES 24
> >
> Unused define ?
>

Thx I'll remove this residual from a previous attempt.


>
> Cheers,
> Emil
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20151105/af3d5f46/attachment-0001.html>