[Mesa-dev] [PATCH 2/4] vl: add drm support for vl_screen

[Emil Velikov]

On 6 November 2015 at 18:01, Liu, Leo <Leo.Liu at amd.com> wrote:
>
>>> +#if GALLIUM_STATIC_TARGETS
>>> +   vscreen->pscreen = dd_create_screen(fd);
>>> +#else
>>> +   if (pipe_loader_drm_probe_fd(&vscreen->dev, fd)) {
>>Add a dup() in the above. So that it reads
>>
>>if (pipe_loader_drm_probe_fd(&vscreen->dev, dup(fd))) {
>>
>
> The dup is handled is in st/va/context.c before calling vl_drm_screen_create
>
Please, move it here ? There little point in getting more of these
ugly (for which I'm to blame) GALLIUM_STATIC_TARGETS macros around
than needed.

Thanks
Emil