[Mesa-dev] [PATCH] egl/dri2: expose srgb configs when KHR_gl_colorspace is available

[Marek Olšák]

On Fri, Nov 6, 2015 at 8:24 PM, Marek Olšák <maraeo at gmail.com> wrote:
> On Thu, Oct 15, 2015 at 2:28 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> On 3 October 2015 at 12:19, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>>> On 3 October 2015 at 02:12, Marek Olšák <maraeo at gmail.com> wrote:
>>>> I'm not sure if this is correct or if we should just return NULL in
>>>> this case like the "case" statement above that does.
>>>>
>>> Actually I was thinking about bailing out when the requested attribute
>>> is set. I.e.
>>>
>>> diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c
>>> index 1740ee3..0450269 100644
>>> --- a/src/egl/drivers/dri2/egl_dri2.c
>>> +++ b/src/egl/drivers/dri2/egl_dri2.c
>>> @@ -237,6 +237,8 @@ dri2_add_config(_EGLDisplay *disp, const
>>> __DRIconfig *dri_config, int id,
>>>
>>>       case __DRI_ATTRIB_FRAMEBUFFER_SRGB_CAPABLE:
>>>          srgb = value != 0;
>>> +         if (!dpy->Extensions.KHR_gl_colorspace && srgb)
>>> +            return NULL;
>>>          break;
>>>
>>>       default:
>>>
>> Guys can anyone give this patch a quick test ? Afaict it is very
>> uncommon to get here, but it still does the right thing.
>
> It doesn't cause any piglit regressions. Sadly, I don't have any EGL
> apps. eglgears_x11 in mesa/demos is already broken for me on VI/Tonga.
> It might be a hw-specific issue.

BTW, I had to fix a compile failure in your patch.

Marek