[Mesa-dev] [PATCH mesa 0/5] nouveau: codegen: Make use of double immediates

Hans de Goede hdegoede at redhat.com
Sun Nov 8 03:58:45 PST 2015


Hi,

On 07-11-15 01:59, Ilia Mirkin wrote:
> Hi Hans,
>
> All pushed. I made a few additional fixes and improvement to fp64
> immediate handling along the way, but all your commits were fine
> as-is. (Except that they enabled fp64 immediates on nv50 implicitly
> which is wrong -- there are no immediate-taking variants on nv50, so I
> fixed that glitch. But only the G200 can do fp64 in the first place,
> and nouveau doesn't actually expose it. Corner case of a corner case
> :) )

Right, I did actually think about that one a bit since Compute capability
1.3 does include doubles, but I figured that since we do not support doubles
on nv50 at all that that would not be an issue, guess I should have
mentioned this in one of the commit messages.

> Thanks for taking care of this... it was a small bit of fp64 which I
> always felt bad about not having finished up. (But not bad enough to
> actually finish it myself.)

You're welcome, this was a fun learning experience for me and I look
forward to doing more work on the codegen bits in the future. But for now
I will be spending my time on a tgsi backend for llvm, so sorry I will
not be looking into:

https://trello.com/c/DX357llE/71-fold-immediates-into-const-load-offsets

Anytime soon, but I do plan to work more on the codegen code in the
future. I will make sure to coordinate with you when I have time to
work on codegen again to avoid doing double work.

Regards,

Hans


More information about the mesa-dev mailing list