[Mesa-dev] [PATCH v2 2/4] vl: add drm support for vl_screen

[Emil Velikov]

Hi Leo,

Please, if you do not understand what was said earlier ask for
clarification rather than just ignoring it.

For example:

On 6 November 2015 at 18:43, Leo Liu <leo.liu at amd.com> wrote:
> This will allow the state trackers to use render nodes
> with screen creation
>
> v2 -dup fd for pipe loader
>
> Signed-off-by: Leo Liu <leo.liu at amd.com>
> Reviewed-by: Christian König <christian.koenig at amd.com>
> ---
>  src/gallium/auxiliary/Makefile.sources   |  3 +-
>  src/gallium/auxiliary/vl/vl_winsys.h     |  6 +++
>  src/gallium/auxiliary/vl/vl_winsys_drm.c | 77 ++++++++++++++++++++++++++++++++
>  3 files changed, 85 insertions(+), 1 deletion(-)
>  create mode 100644 src/gallium/auxiliary/vl/vl_winsys_drm.c
>
> diff --git a/src/gallium/auxiliary/Makefile.sources b/src/gallium/auxiliary/Makefile.sources
> index 6e22ced..82ef5ec 100644
> --- a/src/gallium/auxiliary/Makefile.sources
> +++ b/src/gallium/auxiliary/Makefile.sources
> @@ -349,7 +349,8 @@ VL_SOURCES := \
>
>  # XXX: Nuke this as our dri targets no longer depend on VL.
>  VL_WINSYS_SOURCES := \
> -       vl/vl_winsys_dri.c
> +       vl/vl_winsys_dri.c \
> +       vl/vl_winsys_drm.c
>
>  VL_STUB_SOURCES := \
>         vl/vl_stubs.c
> diff --git a/src/gallium/auxiliary/vl/vl_winsys.h b/src/gallium/auxiliary/vl/vl_winsys.h
> index f6b47c9..df01917 100644
> --- a/src/gallium/auxiliary/vl/vl_winsys.h
> +++ b/src/gallium/auxiliary/vl/vl_winsys.h
> @@ -66,4 +66,10 @@ vl_screen_set_next_timestamp(struct vl_screen *vscreen, uint64_t stamp);
>  void*
>  vl_screen_get_private(struct vl_screen *vscreen);
>
> +struct vl_screen*
> +vl_drm_screen_create(int fd);
> +
> +void
> +vl_drm_screen_destroy(struct vl_screen *vscreen);
> +
>  #endif
> diff --git a/src/gallium/auxiliary/vl/vl_winsys_drm.c b/src/gallium/auxiliary/vl/vl_winsys_drm.c
> new file mode 100644
> index 0000000..1167fcf
> --- /dev/null
> +++ b/src/gallium/auxiliary/vl/vl_winsys_drm.c
> @@ -0,0 +1,77 @@
> +/**************************************************************************
> + *
> + * Copyright 2015 Advanced Micro Devices, Inc.
> + * All Rights Reserved.
> + *
Copying someone else's code does _not_ give you the right to remove
ignore their copyright. This piece here should include Julien and
myself.

Please follow up with patch that corrects things.
Emil