[Mesa-dev] [PATCH 0/7] i965: Use native formats in fs_surface_builder

[Chad Versace]

On Wed 04 Nov 2015, Jason Ekstrand wrote:
> This little patch series converts fs_surface_builder to use native formats
> for doing all of its image_load_store workaround tricks.  If you're willing
> to take as an axiom that we want to not link the backend compiler against
> core mesa, this leaves us with three options:
> 
>  1) Pull mesa_format.h and friends into util
>  2) Use GL enums in fs_surface_builder
>  3) Use native formats in fs_surface_builder
> 
> The first option is a lot of code-shuffling and it's not clear how much
> benifit it would have.  We may want to do it eventually so that gallium and
> core mesa can share format conversion code, but I don't want to go down
> that rabbit-trail right now.
> 
> At first glance, the second and third options look approximately
> equivalent.  However, we don't really want to use GL enums in
> brw_lower_image_format because it's shared by the compiler and the state
> setup code and using GL enums in state setup is kind of gross.  With that
> in mind, I settled on native formats.

I agree. Option 3 is the obvious winner. Use hardware-native formats.