[Mesa-dev] [PATCH 2/7] glsl: Add default precision qualifiers to the symbol table

[Iago Toral]

On Thu, 2015-11-05 at 13:33 +0200, Tapani Pälli wrote:
> From: Iago Toral Quiroga <itoral at igalia.com>
> 
> The GLSL ES spec specifies default precision qualifiers for certain types,
> so populate the symbol table with these.
> 
> Notice that the desktop GLSL spec also indicates defaults for some types
> but this is not really useful since precision qualifiers are completely
> ignored in desktop GLSL.
> 
> v2: simplify and add samplerExternalOES, specified by
>     OES_EGL_image_external (Tapani)

v2 changes look good to me:
Acked-by: Iago Toral Quiroga <itoral at igalia.com>

> ---
>  src/glsl/glsl_parser.yy | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_parser.yy
> index 4636435..4bef345 100644
> --- a/src/glsl/glsl_parser.yy
> +++ b/src/glsl/glsl_parser.yy
> @@ -312,6 +312,17 @@ translation_unit:
>     {
>        delete state->symbols;
>        state->symbols = new(ralloc_parent(state)) glsl_symbol_table;
> +      if (state->es_shader) {
> +         if (state->stage == MESA_SHADER_FRAGMENT) {
> +            state->symbols->add_default_precision_qualifier("int", ast_precision_medium);
> +         } else {
> +            state->symbols->add_default_precision_qualifier("float", ast_precision_high);
> +            state->symbols->add_default_precision_qualifier("int", ast_precision_high);
> +         }
> +         state->symbols->add_default_precision_qualifier("sampler2D", ast_precision_low);
> +         state->symbols->add_default_precision_qualifier("samplerExternalOES", ast_precision_low);
> +         state->symbols->add_default_precision_qualifier("samplerCube", ast_precision_low);
> +      }
>        _mesa_glsl_initialize_types(state);
>     }
>     ;