[Mesa-dev] [PATCH V2 08/12] glsl: add process_qualifier_constant() helper

Emil Velikov emil.l.velikov at gmail.com
Tue Nov 10 04:33:49 PST 2015


On 8 November 2015 at 22:34, Timothy Arceri <t_arceri at yahoo.com.au> wrote:
> From: Timothy Arceri <timothy.arceri at collabora.com>
>
> This helper is similar to the function added as part of the
> ast_layout_expression class but will be used when only the
> ast_expression type is required for the qualifier.
>
> ast_expression is used if qualifier can't have mulitple declorations
typo "multiple declarations"

> or if all but he newest qualifier is simply ignored.
"the"

What is stopping us from introducing this helper first and then
reusing it ? Currently we end up with exact same code twice.
Also I'm struggling to see the function declaration - perhaps we
should just annotate it as static ?

Thanks
Emil


More information about the mesa-dev mailing list