[Mesa-dev] [PATCH 0/7] [v2] Gen9 MCS buffers

Ben Widawsky benjamin.widawsky at intel.com
Wed Nov 11 14:06:14 PST 2015


These patches represent the remaining patches for enabling fast color clears on
GEN9+. Mostly they address feedback from Chad. There is one spot where I am
waiting for him to tell me what he wants for a comment [i965/meta/gen9:
Individually fast clear color attachments]. Hopefully we can get that addressed
without needing a resend just for that. Thanks to Chad, and Neil for the
thorough feedback (and Kristian for helping me debug the implementation on some
of that feedback).

Aside from the removed and rejected patches, there is one new patch where I add
the ccs column to the surface formats table. See that patch for more details,
but in short, this column is for gen9+ ccs and not for the older thing which
resembled ccs functionality.

patches 2 (which is new), 3, 4, and 7 are the ones missing review (please
correct me if someone reviewed any of those and I missed it somehow).

This branch may be found here:
http://cgit.freedesktop.org/~bwidawsk/mesa/log/?h=skl-fast-clear

NOTE: These patches "regress"
piglit.spec.arb_shader_image_load_store.execution.load-from-cleared-image
because of this bug: https://bugs.freedesktop.org/show_bug.cgi?id=92849

Cc: Chad Versace <chad.versace at linux.intel.com>

Ben Widawsky (7):
  i965/skl: Add fast color clear infrastructure
  i965: Add lossless compression to surface format table
  i965/skl: skip fast clears for certain surface formats
  i965/meta/gen9: Individually fast clear color attachments
  Revert "i965/gen9: Disable MCS for 1x color surfaces"
  Revert "i965/gen9: Enable rep clears on gen9"
  i965/gen9: Support fast clears for 32b float

 src/mesa/drivers/dri/i965/brw_context.h         |   2 +
 src/mesa/drivers/dri/i965/brw_meta_fast_clear.c | 166 ++++++--
 src/mesa/drivers/dri/i965/brw_surface_formats.c | 527 +++++++++++++-----------
 src/mesa/drivers/dri/i965/gen8_surface_state.c  |  15 +-
 src/mesa/drivers/dri/i965/intel_mipmap_tree.c   |  32 +-
 src/mesa/drivers/dri/i965/intel_mipmap_tree.h   |  13 +-
 6 files changed, 454 insertions(+), 301 deletions(-)

-- 
2.6.2



More information about the mesa-dev mailing list