[Mesa-dev] [PATCH 12/24] i965: Initialize registers' file to BAD_FILE.

Matt Turner mattst88 at gmail.com
Wed Nov 11 16:09:44 PST 2015


On Wed, Nov 11, 2015 at 4:08 PM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> Actually, your earlier statement:
> "if file == BAD_FILE, no other fields mean anything."
> suggests that we should change fs_reg() to simply set BAD_FILE, and
> not bother initializing the other fields.  That would eliminate one
> of the redundant memsets, and give us valgrind errors if we used
> an uninitialized value.  If we do that, though, we should make
> equals() return true for two BAD_FILE registers.

That's a really good idea. I'll give that a try.


More information about the mesa-dev mailing list