[Mesa-dev] [PATCH v2 10/18] mesa: In helpers, only check driver capability for meta

[Nanley Chery]

On Wed, Nov 11, 2015 at 3:00 PM, Chad Versace <chad.versace at intel.com>
wrote:

> On Fri 30 Oct 2015, Nanley Chery wrote:
> > From: Nanley Chery <nanley.g.chery at intel.com>
> >
> > Make API context and version checks done by the helper functions pass
> > unconditionally while meta is in progress. This transparently makes
> > extension checks solely dependent on struct gl_extensions while in meta.
> >
> > v2. Use 8-bit wide datatype instead GLuint.
> >
> > Signed-off-by: Nanley Chery <nanley.g.chery at intel.com>
> > ---
> >  src/mesa/drivers/common/meta.c | 11 +++++++++++
> >  src/mesa/drivers/common/meta.h |  1 +
> >  src/mesa/main/extensions.h     |  2 +-
> >  src/mesa/main/mtypes.h         |  6 ++++++
> >  src/mesa/main/version.c        |  1 +
> >  5 files changed, 20 insertions(+), 1 deletion(-)
>
>
> > diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h
> > index 10e1586..15964dc 100644
> > --- a/src/mesa/main/mtypes.h
> > +++ b/src/mesa/main/mtypes.h
> > @@ -3802,6 +3802,12 @@ struct gl_extensions
> >     const GLubyte *String;
> >     /** Number of supported extensions */
> >     GLuint Count;
> > +   /**
> > +    * The context version which extension helper functions compare
> against.
> > +    * By default, the value is equal to ctx->Version. This changes to
> ~0,
>
>  ^^^^
> Hanging comma. Was that intentional?
>
>
That was not intentional. I've fixed it locally. Thanks.


> > +    * while meta is in progress.
> > +    */
> > +   GLubyte Version;
> >  };
>
> I approve of this slick version hack for meta.
>
> With or without the hanging comma, this patch is
> Reviewed-by: Chad Versace <chad.versace at intel.com>
>
> I'm done with review today. I'll resume tomorrow.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20151112/a6d73b86/attachment.html>