[Mesa-dev] [PATCH 1/7] [v2] i965/skl: Add fast color clear infrastructure

[Chad Versace]

On Wed 11 Nov 2015, Ben Widawsky wrote:
> Patch was originally called:
> i965/skl: Enable fast color clears on SKL
> 
> Skylake introduces some differences in the way that fast clears are programmed
> and in the restrictions for using fast clears. Since some of these are
> non-obvious, and fast clears are currently disabled globally, we can enable the
> simple stuff here and leave the weirder stuff and separately reviewable work.
> 
> Based on a patch originally from Kristian.
> 
> Note that within this patch the change in scaling factors could be achieved with
> this hunk instead. I've opted to keep things more like how the docs describe it
> however.
> --- a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> +++ b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> @@ -150,9 +150,13 @@ intel_get_non_msrt_mcs_alignment(struct brw_context *brw,
>        /* In release builds, fall through */
>     case I915_TILING_Y:
>        *width_px = 32 / mt->cpp;
> -      *height = 4;
> +      if (brw->gen >= 9)
> +         *height = 2;
> +      else
> +         *height = 4;
> 
> v2: Add braces for the multiline (Matt + Chad)
> Comment updates (requested by Chad)
> Modified commit message
> Commit message from Chad explaining the MCS height change (Chad)
> 
> Cc: Chad Versace <chad.versace at linux.intel.com>
> Signed-off-by: Ben Widawsky <ben at bwidawsk.net>
> Reviewed-by: Neil Roberts <neil at linux.intel.com>
> ---
>  src/mesa/drivers/dri/i965/brw_meta_fast_clear.c | 55 ++++++++++++++++++-------
>  src/mesa/drivers/dri/i965/gen8_surface_state.c  | 16 ++++++-
>  src/mesa/drivers/dri/i965/intel_mipmap_tree.c   | 17 ++++++++
>  src/mesa/drivers/dri/i965/intel_mipmap_tree.h   | 13 ++++--
>  4 files changed, 81 insertions(+), 20 deletions(-)

The diff looks good to me. Fix the patch-in-the-commit-message problem,
and this patch is
Reviewed-by: Chad Versace <chad.versace at intel.com>