[Mesa-dev] [PATCH v2 01/18] mesa/extensions: Remove array sentinel

[Roland Scheidegger]

Am 11.11.2015 um 23:13 schrieb Nanley Chery:
> 
> 
> On Wed, Nov 11, 2015 at 2:07 PM, Chad Versace <chad.versace at intel.com
> <mailto:chad.versace at intel.com>> wrote:
> 
>     On Fri 30 Oct 2015, Nanley Chery wrote:
>     > From: Nanley Chery <nanley.g.chery at intel.com <mailto:nanley.g.chery at intel.com>>
>     >
>     > Simplify future updates to the extension struct array by removing
>     > the sentinel.
>     >
>     > Signed-off-by: Nanley Chery <nanley.g.chery at intel.com <mailto:nanley.g.chery at intel.com>>
> 
>     Patch 1 is
>     Reviewed-by: Chad Versace <chad.versace at intel.com
>     <mailto:chad.versace at intel.com>>
> 
> 
> Thanks.
>  
> 
>     Since your series is long and risks suffering from rebase conflicts,
>     I suggest you push the little cleanup patches (like this one) as soon as
>     you're satisfied with the review.
> 
> 
> Sounds good.
>  
> 
>     Also, could you push a branch for v2 of your series? And put v2 in its
>     name? That would help me review it since it no longer applies cleanly to
>     master.
> 
> 
> Sure, the branch is located here: 
> http://cgit.freedesktop.org/~nchery/mesa/log/?h=ext_safev2
> <http://cgit.freedesktop.org/%7Enchery/mesa/log/?h=ext_safev2>
> 
> 
> 

Something of this series broke msvc compilation, albeit I'm not quite
sure what advanced feature this is using:
  Compiling build\windows-x86-debug\mesa\main\format_unpack.c ...
format_pack.c
format_unpack.c
[..]\mesa-msvc\src\mesa\main\extensions.h(78) : error C2133:
'_mesa_extension_table' : unknown size
  Compiling src\mesa\main\formatquery.c ...
scons: *** [build\windows-x86-debug\mesa\main\ff_fragment_shader.obj]
Error 2

Roland