[Mesa-dev] [PATCH] nir/vars_to_ssa: Delete dead output set code

Connor Abbott cwabbott0 at gmail.com
Thu Nov 12 21:58:39 PST 2015


Reviewed-by: Connor Abbott <cwabbott0 at gmail.com>

On Fri, Nov 13, 2015 at 12:53 AM, Jason Ekstrand <jason at jlekstrand.net> wrote:
> This was a remnant of an early attempt to handle output reads in
> vars_to_ssa.  That attempt was abandon a long time ago but these few lines
> were aparently left in the pass and managed to evade review.
> ---
>  src/glsl/nir/nir_lower_vars_to_ssa.c | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/src/glsl/nir/nir_lower_vars_to_ssa.c b/src/glsl/nir/nir_lower_vars_to_ssa.c
> index df24510..e670dbd 100644
> --- a/src/glsl/nir/nir_lower_vars_to_ssa.c
> +++ b/src/glsl/nir/nir_lower_vars_to_ssa.c
> @@ -879,10 +879,6 @@ nir_lower_vars_to_ssa_impl(nir_function_impl *impl)
>     state.add_to_direct_deref_nodes = true;
>     nir_foreach_block(impl, register_variable_uses_block, &state);
>
> -   struct set *outputs = _mesa_set_create(state.dead_ctx,
> -                                          _mesa_hash_pointer,
> -                                          _mesa_key_pointer_equal);
> -
>     bool progress = false;
>
>     nir_metadata_require(impl, nir_metadata_block_index);
> @@ -916,9 +912,6 @@ nir_lower_vars_to_ssa_impl(nir_function_impl *impl)
>           def_stack_push(node, &load->def, &state);
>        }
>
> -      if (deref->var->data.mode == nir_var_shader_out)
> -         _mesa_set_add(outputs, node);
> -
>        foreach_deref_node_match(deref, lower_copies_to_load_store, &state);
>     }
>
> --
> 2.5.0.400.gff86faf
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list