[Mesa-dev] [PATCH 1/4] glsl: Silence ignored qualifier warning

Timothy Arceri timothy.arceri at collabora.com
Wed Nov 18 13:24:11 PST 2015


On Wed, 2015-11-18 at 09:44 -0800, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> 
> I think the intention was to mark the "this" parameter as const, but
> const goes on the other end to do that.
> 
> In file included from glsl_symbol_table.cpp:26:0:
> ast.h:339:35: warning: type qualifiers ignored on function return type [
> -Wignored-qualifiers]
>     const bool is_single_dimension()
>                                    ^
> 

Whoops. Reviewed-by: Timothy Arceri <timothy.arceri at collabora.com>


> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> Cc: Timothy Arceri <t_arceri at yahoo.com.au>
> ---
>  src/glsl/ast.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/glsl/ast.h b/src/glsl/ast.h
> index 1b75234..ae76342 100644
> --- a/src/glsl/ast.h
> +++ b/src/glsl/ast.h
> @@ -336,7 +336,7 @@ public:
>        array_dimensions.push_tail(&dim->link);
>     }
>  
> -   const bool is_single_dimension()
> +   bool is_single_dimension() const
>     {
>        return this->array_dimensions.tail_pred->prev != NULL &&
>               this->array_dimensions.tail_pred->prev->is_head_sentinel();


More information about the mesa-dev mailing list