[Mesa-dev] [PATCH 1/2] mesa/extensions: Sort the extension table alphabetically

[Ilia Mirkin]

On Wed, Nov 18, 2015 at 6:47 PM, Matt Turner <mattst88 at gmail.com> wrote:
> On Wed, Nov 18, 2015 at 3:01 PM, Nanley Chery <nanleychery at gmail.com> wrote:
>> From: Nanley Chery <nanley.g.chery at intel.com>
>>
>> Make it easier to determine where to add new extensions.
>> Performed with the vim sort command.
>
> Well, I think I'm obligated to review such a patch :)
>
>> Signed-off-by: Nanley Chery <nanley.g.chery at intel.com>
>> ---
>>  src/mesa/main/extensions_table.h | 173 +++++++++++++++++++++------------------
>>  1 file changed, 92 insertions(+), 81 deletions(-)
>>
>> diff --git a/src/mesa/main/extensions_table.h b/src/mesa/main/extensions_table.h
>> index d12fd9f..4b42863 100644
>> --- a/src/mesa/main/extensions_table.h
>> +++ b/src/mesa/main/extensions_table.h
>> @@ -1,8 +1,30 @@
>> +/* The extension table is alphabetically sorted by the extension name string column. */
>> +
>>  #define GLL 0
>>  #define GLC 0
>>  #define ES1 0
>>  #define ES2 0
>>  #define  x ~0
>
> I'd probably put a blank line between the last #define and the first EXT(...)
>
> I trust sort, so

Be careful who you trust:

$ LC_ALL=en_US.utf8 sort
A
a
a
A
$ LC_ALL=C sort
A
a
A
a

There's an implicit ^D which I typed after the second line...
hopefully we're not dealing with locale-sensitive functions.

>
> Reviewed-by: Matt Turner <mattst88 at gmail.com>
>
>> +EXT(3DFX_texture_compression_FXT1           , TDFX_texture_compression_FXT1          , GLL, GLC,  x ,  x , 1999)
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev