[Mesa-dev] [PATCH 6/8] nir: Add nir_texop_samples_identical opcode

[Jason Ekstrand]

On Wed, Nov 18, 2015 at 4:23 PM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> On Wednesday, November 18, 2015 03:46:52 PM Ian Romanick wrote:
>> From: Ian Romanick <ian.d.romanick at intel.com>
>>
>> This is the NIR analog to GLSL IR ir_samples_identical.  However, the
>> NIR has an extra source.  This is a fake sample index with a type
>> nir_tex_src_ms_index.  This enables backends to (likely) share more code
>> with the existing nir_texop_txf_ms implementation.
>>
>> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
>
> The extra source is a little weird, but I see why you did it - it makes
> it really easy to fall through to the existing code.  Seems okay.
> Fortunately, none of this is baked in stone, so we can always change it
> later if we really want :)

I'm not a huge fan of it either.  I'm not NAK anything based on it,
but it does seem a bit awkward.
--Jason