[Mesa-dev] [PATCH v2 1/2] mesa: Add KBL PCI IDs and platform information.

Ilia Mirkin imirkin at alum.mit.edu
Fri Nov 20 11:09:46 PST 2015


On Fri, Nov 20, 2015 at 2:01 PM, Ben Widawsky <ben at bwidawsk.net> wrote:
>> > FWIW I wholeheartedly agree with this line of reasoning. I never put
>> > the version info into my commits either, and find it
>> > confusing/misleading when others do. I want to know the final state of
>> > things when looking at the commit 1 year from now, not the 20-step
>> > process and all the wrong turns to get there.
>
> When I'm lazy, the commit message doesn't reflect the final state and you need
> to read through the version info to get the end result. That is not great
> because I am usually lazy. However aside from that case, I don't see what is
> confusing about it - it's at the bottom. Don't read it if you don't want to.

That's the problem -- with the revision history in there, it's really
tempting not to update the original. And then I'm stuck reading
sequences of "do; undo; do; undo" and figuring out what the last
desired state was. If there's no version history, then you're stuck
making sure that the commit description matches reality.

  -ilia


More information about the mesa-dev mailing list