[Mesa-dev] [PATCH 4/9] i965/fs: respect force_sechalf/force_writemask_all in CSE

[Kenneth Graunke]

On Thursday, November 19, 2015 03:29:18 AM Matt Turner wrote:
> On Thu, Nov 19, 2015 at 2:05 AM, Iago Toral Quiroga <itoral at igalia.com> wrote:
> > From: Connor Abbott <connor.w.abbott at intel.com>
> >
> > Reviewed-by: Iago Toral Quiroga <itoral at igalia.com>
> > ---
> 
> In fact, I think Ken ran into this very bug last week.
> 
> Reviewed-by: Matt Turner <mattst88 at gmail.com>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev

I didn't, actually - I was writing vec4 code, and had only set
BRW_MASK_DISABLE in the generator, without setting force_writemask_all
in the IR.  So CSE didn't know to set it on the MOVs it created.

Once I actually flagged the instructions properly, it worked fine.

Patch 4 is:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20151121/656a35b3/attachment.sig>