[Mesa-dev] [PATCH] gallium: remove unused function declarations

[Ilia Mirkin]

Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>

I can indeed confirm that those functions are nowhere to be found,
makes sense to remove the declarations as well.

Oded's issue seems likely to stem from some mismatch between the
loader and what's being loaded...

On Sun, Nov 22, 2015 at 5:45 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> Unused as of commit 23fb11455b4 "{st,targets}/dri: use static/dynamic
> pipe-loader"
>
> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
> ---
>
> Noticed when Oded reported missing symbol drisw_create_screen in
> swrast_dri.so. Still not sure how that's even remotely possible.
>
> -Emil
>
>  src/gallium/include/state_tracker/drisw_api.h | 5 -----
>  src/gallium/state_trackers/dri/dri_screen.h   | 1 -
>  2 files changed, 6 deletions(-)
>
> diff --git a/src/gallium/include/state_tracker/drisw_api.h b/src/gallium/include/state_tracker/drisw_api.h
> index cd5a27e..03d5ee4 100644
> --- a/src/gallium/include/state_tracker/drisw_api.h
> +++ b/src/gallium/include/state_tracker/drisw_api.h
> @@ -20,9 +20,4 @@ struct drisw_loader_funcs
>                         void *data, int x, int y, unsigned width, unsigned height, unsigned stride);
>  };
>
> -/**
> - * Implemented by the drisw target.
> - */
> -struct pipe_screen * drisw_create_screen(struct drisw_loader_funcs *lf);
> -
>  #endif
> diff --git a/src/gallium/state_trackers/dri/dri_screen.h b/src/gallium/state_trackers/dri/dri_screen.h
> index 4bcb029..4545990 100644
> --- a/src/gallium/state_trackers/dri/dri_screen.h
> +++ b/src/gallium/state_trackers/dri/dri_screen.h
> @@ -147,7 +147,6 @@ dri_destroy_screen_helper(struct dri_screen * screen);
>  void
>  dri_destroy_screen(__DRIscreen * sPriv);
>
> -extern struct pipe_screen *kms_swrast_create_screen(int fd);
>  extern const struct __DriverAPIRec dri_kms_driver_api;
>
>  extern const struct __DriverAPIRec galliumdrm_driver_api;
> --
> 2.6.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev