[Mesa-dev] [PATCH 5/7] mesa: accept TYPE_PUSH/POP_GROUP with glDebugMessageInsert

[Timothy Arceri]

On Sun, 2015-11-22 at 23:21 +0000, Emil Velikov wrote:
> These new (relative to ARB_debug_output) tokens, have been explicitly
> separated from the existing ones in the spec text. With the reference
> to glDebugMessageInsert was dropped.
> 
> At the same time, further down the spec says:
>    "The value of <type> must be one of the values from Table 5.4"
> 
> ... and these two are listed in Table 5.4.
>
> The GL 4.3 and GLES 3.2 do not give any hints on the former
> 'definition', plus CTS requires that the tokens are valid values for
> glDebugMessageInsert.

Either way this looks like a spec bug.

IMO it don't make sense to be able to use these types as message types
inserted by the program, they should only be inserted when a pop/push is done.


> 
> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
> ---
>  src/mesa/main/errors.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mesa/main/errors.c b/src/mesa/main/errors.c
> index b9e5f4f..dd9b800 100644
> --- a/src/mesa/main/errors.c
> +++ b/src/mesa/main/errors.c
> @@ -923,9 +923,9 @@ validate_params(struct gl_context *ctx, unsigned caller,
>     case GL_DEBUG_TYPE_PORTABILITY_ARB:
>     case GL_DEBUG_TYPE_OTHER_ARB:
>     case GL_DEBUG_TYPE_MARKER:
> -      break;
>     case GL_DEBUG_TYPE_PUSH_GROUP:
>     case GL_DEBUG_TYPE_POP_GROUP:
> +      break;
>     case GL_DONT_CARE:
>        if (caller == CONTROL)
>           break;