[Mesa-dev] [PATCH] gallium: build virgl by default.

[Albert Freeman]

On 23 November 2015 at 03:17, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> On Sun, Nov 22, 2015 at 9:28 PM, Dave Airlie <airlied at gmail.com> wrote:
>> From: Dave Airlie <airlied at redhat.com>
>>
>> No reason not to build this, it has no external
>> requirements at the moment.
>
> Not that I object, but what's the policy around these defaults? Should
> we also add nouveau? freedreno? vc4?
>
> Of course my personal preference would be to just error the build if
> no drivers are specified... but I guess that won't work for some
> people?
I do agree with this, it will cause some of those people to look
through all the gallium drivers to see which ones they need (maybe
that will result in them using more...), reduce compilation time and
decrease used storage space. It should also prevent people from not
including the drivers they need (only for gallium drivers). Of course
it will break a few peoples builds (though they will also reap the
benefits), but almost everyone uses the flag.

The only other fair alternative is to build all the drivers, which has
a negative impact on all those points (excluding broken builds) +
dependency issues (other broken builds (less though: some people would
have the required dependencies)).
>
>>
>> Signed-off-by: Dave Airlie <airlied at redhat.com>
>> ---
>>  configure.ac | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index 120c93e..5479ba6 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -861,13 +861,13 @@ AC_ARG_ENABLE([gallium-tests],
>>  # Option for Gallium drivers
>>
>>  # Keep this in sync with the --with-gallium-drivers help string default value
>> -GALLIUM_DRIVERS_DEFAULT="r300,r600,svga,swrast"
>> +GALLIUM_DRIVERS_DEFAULT="r300,r600,svga,swrast,virgl"
>>
>>  AC_ARG_WITH([gallium-drivers],
>>      [AS_HELP_STRING([--with-gallium-drivers@<:@=DIRS...@:>@],
>>          [comma delimited Gallium drivers list, e.g.
>>          "i915,ilo,nouveau,r300,r600,radeonsi,freedreno,svga,swrast,vc4,virgl"
>> -        @<:@default=r300,r600,svga,swrast@:>@])],
>> +        @<:@default=r300,r600,svga,swrast,virgl@:>@])],
>>      [with_gallium_drivers="$withval"],
>>      [with_gallium_drivers="$GALLIUM_DRIVERS_DEFAULT"])
>>
>> --
>> 2.4.3
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev