[Mesa-dev] [PATCH 3/5] i965: Check base format to determine whether to use tiled memcpy

[Neil Roberts]

Ben Widawsky <ben at bwidawsk.net> writes:

> I really don't know the corner cases well enough, but concept seems
> good to me. In particular, I assume this is now going to return false
> for more cases than previously - and that's okay, I guess?

In practice I don't think it will disable any extra formats because the
intel_get_memcpy function which this calls is a lot more strict about
which specific formats it takes anyway. It's a bit weird because
intel_get_memcpy explicitly allows BGRX and RGBX so Jason's original
patch could have been implemented by just removing that explicit
support. However now that the condition is being changed to look at
_BaseFormat instead I think it does make more sense to leave the check
in intel_gettexsubimage_tiled_memcpy.

Regards,
- Neil