[Mesa-dev] [PATCH 1/8] st/va: fix post process dirty area handling

[Julien Isorce]

Make sense it was a copy past I did from vlVdpPresentationQueueDisplay.
I tested this change and works fine.
Thx for catching this.

(feel free to set "clear_dirty" param of vl_compositor_render to false even
if it will be ignored anyway)

Reviewed-by: Julien Isorce <j.isorce at samsung.com>

On 23 November 2015 at 14:37, Christian König <deathsimple at vodafone.de>
wrote:

> From: Christian König <christian.koenig at amd.com>
>
> The dirty area in this call isn't related to the screen at all.
>
> Signed-off-by: Christian König <christian.koenig at amd.com>
> ---
>  src/gallium/state_trackers/va/picture.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/src/gallium/state_trackers/va/picture.c
> b/src/gallium/state_trackers/va/picture.c
> index a37a9b7..d0aa2d8 100644
> --- a/src/gallium/state_trackers/va/picture.c
> +++ b/src/gallium/state_trackers/va/picture.c
> @@ -722,7 +722,6 @@ handleVAProcPipelineParameterBufferType(vlVaDriver
> *drv, vlVaContext *context, v
>  {
>     struct u_rect src_rect;
>     struct u_rect dst_rect;
> -   struct u_rect *dirty_area;
>     vlVaSurface *src_surface;
>     VAProcPipelineParameterBuffer *pipeline_param;
>     struct pipe_surface **surfaces;
> @@ -763,12 +762,10 @@ handleVAProcPipelineParameterBufferType(vlVaDriver
> *drv, vlVaContext *context, v
>     dst_rect.x1 = pipeline_param->output_region->x +
> pipeline_param->output_region->width;
>     dst_rect.y1 = pipeline_param->output_region->y +
> pipeline_param->output_region->height;
>
> -   dirty_area = drv->vscreen->get_dirty_area(drv->vscreen);
> -
>     vl_compositor_clear_layers(&drv->cstate);
>     vl_compositor_set_buffer_layer(&drv->cstate, &drv->compositor, 0,
> src_surface->buffer, &src_rect, NULL, VL_COMPOSITOR_WEAVE);
>     vl_compositor_set_layer_dst_area(&drv->cstate, 0, &dst_rect);
> -   vl_compositor_render(&drv->cstate, &drv->compositor, psurf,
> dirty_area, true);
> +   vl_compositor_render(&drv->cstate, &drv->compositor, psurf, NULL,
> true);
>
>     screen->fence_reference(screen, &src_surface->fence, NULL);
>     drv->pipe->flush(drv->pipe, &src_surface->fence, 0);
> --
> 2.5.0
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20151123/18b4124d/attachment.html>