[Mesa-dev] [PATCH] mesa: remove ARB_geometry_shader4

[Emil Velikov]

Hi Marta,

On 24 November 2015 at 09:20, Marta Lofstedt
<marta.lofstedt at linux.intel.com> wrote:
> From: Marta Lofstedt <marta.lofstedt at intel.com>
>
> Since all drivers support OpenGL 3.2 geometry shaders,
> there is no reason to keep the ARB_geometry_shader4.
>
How about we give a better justification about this - after all there
are drivers which don't yet support GL 3.2, if ever. Iirc there has
been a few discussions about doing this so perhaps add a reference to
one/some of them ?

Also worth mentioning that currently the extension is disabled/incomplete ?

> Signed-off-by: Marta Lofstedt <marta.lofstedt at linux.intel.com>
> ---
>  src/mapi/glapi/gen/ARB_geometry_shader4.xml | 57 -----------------------------
>  src/mapi/glapi/gen/Makefile.am              |  1 -
>  src/mapi/glapi/gen/gl_API.xml               |  2 -
>  src/mesa/main/api_validate.c                |  2 +-
>  src/mesa/main/config.h                      |  2 +-
>  src/mesa/main/context.h                     |  3 +-
>  src/mesa/main/dlist.c                       |  6 +--
>  src/mesa/main/get.c                         |  7 ----
>  src/mesa/main/get_hash_params.py            | 12 ++----
>  src/mesa/main/mtypes.h                      |  3 +-
>  10 files changed, 11 insertions(+), 84 deletions(-)
>  delete mode 100644 src/mapi/glapi/gen/ARB_geometry_shader4.xml

> --- a/src/mapi/glapi/gen/gl_API.xml
> +++ b/src/mapi/glapi/gen/gl_API.xml
> @@ -7975,8 +7975,6 @@
>
>  <!-- 46. GL_ARB_framebuffer_sRGB -->
>
> -<xi:include href="ARB_geometry_shader4.xml" xmlns:xi="http://www.w3.org/2001/XInclude"/>
> -
Bring back the placeholder - could even note that there are no plans
to implement this extension.

<!-- 47. GL_ARB_geometry_shader4 -->

Regards,
Emil