[Mesa-dev] [PATCH 1/4] glsl: remove trailing spaces in ast_to_hir.cpp

Iago Toral itoral at igalia.com
Tue Nov 24 04:43:27 PST 2015


On Tue, 2015-11-24 at 12:26 +0000, Emil Velikov wrote:
> Hi Iago,
> 
> I'm not sure how others feel on the topic, but imho it's not that
> useful to have XX patches where each addresses a couple of lines of
> whitespace issues. Squashing the lot per section (one for glsl,
> another for i965) seems like a better thing.
> 
> Then again let see if others feel the same way.
> -Emil

Yeah, I was tempted to do that but then I thought that some people might
prefer to ignore the trailing spaces to keep history in some of these
and that keeping the patches separate could help identify these cases
during the review, but if this is not useful and the general feeling is
that we rather see this type of changes sent squashed for review I'll
take that into account in future submissions.

BTW, I did not mention it but I think these should be squashed before
pushing like you proposed.

Iago



More information about the mesa-dev mailing list