[Mesa-dev] Mesa (master): gallium/util: remove the fake format helpers for bptc and etc2

[Ilia Mirkin]

On Tue, Nov 24, 2015 at 1:37 AM, Michel Dänzer <michel at daenzer.net> wrote:
> On 24.11.2015 01:21, Ilia Mirkin wrote:
>> Module: Mesa
>> Branch: master
>> Commit: 1c7d0a6aa4f5cb38af7e281e1e5437cd1a20f781
>> URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=1c7d0a6aa4f5cb38af7e281e1e5437cd1a20f781
>>
>> Author: Ilia Mirkin <imirkin at alum.mit.edu>
>> Date:   Sat Nov 21 10:44:00 2015 -0500
>>
>> gallium/util: remove the fake format helpers for bptc and etc2
>>
>> This was a silly hack that kept growing and growing. Instead, just write
>> NULLs for those functions. No need to have helpers that just assert(0)
>> when you call them.
>>
>> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
>> Reviewed-by: Marek Olšák <marek.olsak at amd.com>
>> Reviewed-by: Roland Scheidegger <sroland at vmware.com>
>
> This change broke make check, specifically llvmpipe's lp_test_format:

Hmmm... odd. Calling any of those should have ended up in asserts
anyways. I did realize that I forgot to add ASTC to the
no-softpipe/llvmpipe list, so I'll do that, but those were all added
in the next commit. Will also investigate what I mucked up here,
thanks for the heads up.

  -ilia