[Mesa-dev] [PATCH 1/2] llvmpipe: don't test for unsupported formats in lp_test_format

sroland at vmware.com sroland at vmware.com
Tue Nov 24 08:56:35 PST 2015


From: Roland Scheidegger <sroland at vmware.com>

Removing the fake format helpers (1c7d0a6aa4f5cb38af7e281e1e5437cd1a20f781)
caused this to fail. These formats were never supported, but previously
they would have asserted in the generated jit functions (which, due to lack
of test cases for these formats, were never called) whereas we now assert when
trying to build the jit function. So, skip them completely.

This fixes https://bugs.freedesktop.org/show_bug.cgi?id=93092
---
 src/gallium/drivers/llvmpipe/lp_test_format.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/src/gallium/drivers/llvmpipe/lp_test_format.c b/src/gallium/drivers/llvmpipe/lp_test_format.c
index 0640a21..3f2ed84 100644
--- a/src/gallium/drivers/llvmpipe/lp_test_format.c
+++ b/src/gallium/drivers/llvmpipe/lp_test_format.c
@@ -382,6 +382,18 @@ test_all(unsigned verbose, FILE *fp)
          continue;
       }
 
+      /* only have util fetch func for etc1 */
+      if (format_desc->layout == UTIL_FORMAT_LAYOUT_ETC &&
+          format != PIPE_FORMAT_ETC1_RGB8) {
+         continue;
+      }
+
+      /* missing fetch funcs */
+      if (format_desc->layout == UTIL_FORMAT_LAYOUT_BPTC ||
+          format_desc->layout == UTIL_FORMAT_LAYOUT_ASTC) {
+         continue;
+      }
+
       if (!test_one(verbose, fp, format_desc)) {
            success = FALSE;
       }
-- 
2.1.4



More information about the mesa-dev mailing list