[Mesa-dev] [PATCH 1/3] dri_interface: Introduce __DRI_IMAGE_USE_SCANOUT_ROTATION_* flags (v3)

[Michel Dänzer]

On 26.11.2015 11:01, Vivek Kasireddy wrote:
> On Wed, 25 Nov 2015 18:38:50 +0900
> Michel Dänzer <michel at daenzer.net> wrote:
> 
>> On 21.11.2015 12:38, Vivek Kasireddy wrote:
>>> These flags can be used by the DRI driver to set additional
>>> requirements such as tiling while creating buffers.
>>>
>>> v2: Added a brief comment to explain the rotation orientation.
>>>
>>> v3: Corrected a typo in the comment added in v2 and removed an empty
>>>     line.
>>>
>>> Cc: Michel Danzer <michel at daenzer.net>
>>> Signed-off-by: Vivek Kasireddy <vivek.kasireddy at intel.com>
>>
>> The series is
>>
>> Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>
>>
>>
>> Do you need somebody to push the patches for you?
> 
> Yes please!

I was getting ready to push these, but it occurred to me that we
normally don't add new APIs without any code implementing/using them. Do
you have a (i965?) driver patch implementing these flags?

Also, I wonder if we need to add code to other drivers returning NULL if
any of these new flags are specified, until they are actually handled
correctly.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer