[Mesa-dev] [PATCH v2 6/8] mesa: accept TYPE_PUSH/POP_GROUP with glDebugMessageInsert

[Emil Velikov]

On 26 November 2015 at 04:55, Timothy Arceri
<timothy.arceri at collabora.com> wrote:
> On Thu, 2015-11-26 at 00:36 +0000, Emil Velikov wrote:
>> These new (relative to ARB_debug_output) tokens, have been explicitly
>> separated from the existing ones in the spec text. With the reference
>> to glDebugMessageInsert was dropped.
>>
>> At the same time, further down the spec says:
>>    "The value of <type> must be one of the values from Table 5.4"
>>
>> ... and these two are listed in Table 5.4.
>>
>> The GL 4.3 and GLES 3.2 do not give any hints on the former
>> 'definition', plus CTS requires that the tokens are valid values for
>> glDebugMessageInsert.
>
> I still think this is a spec bug but if it helps pass the tests I guess
> it doesn't do much harm.
>
Yes it is a bit of "why on earth anyone would want to do that" kind of
thing, but it shouldn't hurt anything afaict. GL 4.3 was released some
3 years ago, so I doubt fixing this spec will help much. If apps are
already using it vendors will just add workaround to still allow it.

> Reviewed-by: Timothy Arceri <timothy.arceri at collabora.com>
>
Thanks
Emil