[Mesa-dev] [PATCH 0/9] Move nir/glsl to src/compiler

Jason Ekstrand jason at jlekstrand.net
Fri Nov 27 09:54:39 PST 2015


On Nov 25, 2015 1:27 PM, "Emil Velikov" <emil.l.velikov at gmail.com> wrote:
>
> Hello all,
>
> Some of us have been thinking about moving nir out of glsl, and fleshing
> out some common helper (static library) that is use by both. So here it
> is - src/compiler.
>
> The modules (libcompiler, libnir and libglsl) are unfortunately not
> really independent.
>  - libcompiler - compile time (mesa ir, glsl ir, util), link - util
>  - libglsl - compile (compiler, mesa ir, util), link - compiler, util
>  - libnir - compile (compiler, mesa ir, glsl ir, util), link - compiler,
> util

Thanks for working on this!  Before I make comments, its worth noting that
the biggest churn is just moving files.  If we don't have the linking
details figured out, that shouldn't block landing the file churn.

I was kind of hoping that we could have a libnir that doesn't require
glsl.  It would be good for freedreno and vc4 among other things.  Maybe
split things up differently?

- libcompilerutil: just glsl_types and shader_enums
- libglsl
- libnir
- libcompiler

Neither libglsl nor libnir should depend on the other.  If you want
everything, you use libcompiler which would depend on both libglsl and
libnir and also bring in glsl_to_nir.

Would that be practical?  (I don't know autotools or libtool all that well.)

> With the above in mind the headers are extremely fragile. Despite that
> things work fine based on my testing.
>
> Note: the series depends (some some trivial dependencies) on the
> no-extern-c patches send yesterday.
>
> This lot (incl. the requirement) can be found in branch nir-glsl-move at
> https://github.com/evelikov/Mesa/
>
> Comments, suggestions and ack/nak of the idea and approach are
> appreciated.
>
> Cheers,
> Emil
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20151127/29534986/attachment.html>


More information about the mesa-dev mailing list