[Mesa-dev] [Mesa-stable] [PATCH] clover: Check the return value of pipe_loader_probe() when probing for devices

[Francisco Jerez]

Emil Velikov <emil.l.velikov at gmail.com> writes:

> On 28 November 2015 at 17:06, Francisco Jerez <currojerez at riseup.net> wrote:
>
>> ... you're free to propose such a change as a
>> separate series as long as you fix the documentation, all users and
>> back-ends of pipe-loader, if you consider it worth doing -- I personally
>> don't.
>>
> That what I was wondering about. Thanks
>
>> I don't think it boils down to that. ...
>
> I got the idea that you approve of the patch the first time around,
> despite it (the approval) blurring with the lengthy justification of
> the improved version.
>
There was something fishy going on in this patch, it was obviously
papering over a bug elsewhere, so a justification was more than
appropriate IMO...

> Perhaps we (I'm also guilty on that one) can use a more explicit
> "looks good, but let's we use X, because ..." approach. Otherwise
> things tend to get a bit strange ?
>
> Thanks
> Emil
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 212 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20151129/6bc61aee/attachment.sig>