[Mesa-dev] [PATCH 3/3] xvmc: force assertion in XvMC tests

[Emil Velikov]

Hi Giuseppe,

On 28 November 2015 at 15:43, Giuseppe Bilotta
<giuseppe.bilotta at gmail.com> wrote:
> This follows the src/util/u_atomic_test model of undefining NDEBUG
> unconditionally throughouth the XvMC tests, to force asserts regardless
> of debug mode.
>
> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta at gmail.com>
> ---
>  src/gallium/state_trackers/xvmc/tests/test_blocks.c     | 2 ++
>  src/gallium/state_trackers/xvmc/tests/test_context.c    | 2 ++
>  src/gallium/state_trackers/xvmc/tests/test_rendering.c  | 2 ++
>  src/gallium/state_trackers/xvmc/tests/test_subpicture.c | 2 ++
>  src/gallium/state_trackers/xvmc/tests/test_surface.c    | 2 ++
>  5 files changed, 10 insertions(+)
>
> diff --git a/src/gallium/state_trackers/xvmc/tests/test_blocks.c b/src/gallium/state_trackers/xvmc/tests/test_blocks.c
> index a35838f..4c89951 100644
> --- a/src/gallium/state_trackers/xvmc/tests/test_blocks.c
> +++ b/src/gallium/state_trackers/xvmc/tests/test_blocks.c
> @@ -25,6 +25,8 @@
>   *
>   **************************************************************************/
>
> +/* Force assertions, even on debug builds. */
The comment should say "...even on release builds". Same for the rest
of the patch.

I've always wondered if anyone will get to fixing these - be that with
current approach or reworking the tests.

-Emil