[Mesa-dev] [PATCH v2] egl/dri2: expose srgb configs when KHR_gl_colorspace is available

[Mauro Rossi]

Hi Emil,

I confirm I tested on lollipop-x86 with i965 on Intel HD4000, X3100 and
nouveau with GT210,
and I saw no regressions on android-x86.

Mauro


2015-11-29 17:48 GMT+01:00 Emil Velikov <emil.l.velikov at gmail.com>:

> Otherwise the user has no way of using it, and we'll try to access the
> linear one.
>
> v2:
>  - Bail out when KHR_gl_colorspace is missing and srgb is set (Marek)
>
> Cc: Mauro Rossi <issor.oruam at gmail.com>
> Cc: Chih-Wei Huang <cwhuang at android-x86.org>
> Cc: "11.0 11.1" <mesa-stable at lists.freedesktop.org>
> Fixes: c2c2e9ab604(egl: implement EGL_KHR_gl_colorspace (v2))
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91596
> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
> ---
>
> Mauro, I thought you already tested this but I cannot find any traces.
>
> Thanks
> Emil
>
>  src/egl/drivers/dri2/egl_dri2.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/src/egl/drivers/dri2/egl_dri2.c
> b/src/egl/drivers/dri2/egl_dri2.c
> index d34b161..8f50f0c 100644
> --- a/src/egl/drivers/dri2/egl_dri2.c
> +++ b/src/egl/drivers/dri2/egl_dri2.c
> @@ -235,6 +235,8 @@ dri2_add_config(_EGLDisplay *disp, const __DRIconfig
> *dri_config, int id,
>
>        case __DRI_ATTRIB_FRAMEBUFFER_SRGB_CAPABLE:
>           srgb = value != 0;
> +         if (!disp->Extensions.KHR_gl_colorspace && srgb)
> +            return NULL;
>           break;
>
>        default:
> --
> 2.6.2
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20151129/2329ace4/attachment.html>