[Mesa-dev] [PATCH 06/12] mesa: Drop apparently typoed GL_ALL_CLIENT_ATTRIB_BITS.

[Ian Romanick]

On 11/25/2015 07:10 PM, Eric Anholt wrote:
> GL_ALL_ATTRIB_BITS is a thing, and GL_CLIENT_ALL_ATTRIB_BITS, but I don't
> see GL_ALL_CLIENT_ATTRIB_BITS in my grepping of khronos XML, GL extension
> specs, GL 1.1, GL 2.2, and GL 4.4.

Hm... it is in include/GL/gl.h.  git-blame says:

commit a8b07a539b42b04111f48aa145bc3b2633fd5387
Author: Brian Paul <brian.paul at tungstengraphics.com>
Date:   Tue Aug 28 22:49:32 2001 +0000

    added OpenGL 1.3 tokens and prototypes

Maybe from an early version of the spec?
b
> ---
>  src/mapi/glapi/gen/gl_API.xml        | 1 -
>  src/mesa/main/tests/enum_strings.cpp | 4 +---
>  2 files changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_API.xml
> index faf9263..b87ae6e 100644
> --- a/src/mapi/glapi/gen/gl_API.xml
> +++ b/src/mapi/glapi/gen/gl_API.xml
> @@ -3139,7 +3139,6 @@
>      <enum name="EDGE_FLAG_ARRAY_POINTER"                  value="0x8093"/>
>      <enum name="CLIENT_PIXEL_STORE_BIT"                   value="0x00000001"/>
>      <enum name="CLIENT_VERTEX_ARRAY_BIT"                  value="0x00000002"/>
> -    <enum name="ALL_CLIENT_ATTRIB_BITS"                   value="0xFFFFFFFF"/>
>      <enum name="CLIENT_ALL_ATTRIB_BITS"                   value="0xFFFFFFFF"/>
>  
>      <function name="ArrayElement" deprecated="3.1" exec="dynamic">
> diff --git a/src/mesa/main/tests/enum_strings.cpp b/src/mesa/main/tests/enum_strings.cpp
> index 48426a4..8b92026 100644
> --- a/src/mesa/main/tests/enum_strings.cpp
> +++ b/src/mesa/main/tests/enum_strings.cpp
> @@ -94,9 +94,7 @@ const struct enum_info everything[] = {
>     /* A bitfield where Mesa uses a different value from Khronos. */
>     { 0x000fffff, "GL_ALL_ATTRIB_BITS" },
>  
> -   /* A bitfield in the table where Mesa uses a different name from Khronos,
> -    * and we fail to return its string anyway!
> -    */
> +   /* A bitfield in the table, where we fail to return its string anyway! */
>     { (int)0xffffffff, "0xffffffff" },
>  
>     { 0, NULL }
>