[Mesa-dev] [RFC] Fix for clang compiler issue as reported in Bug 91826

Serge Martin (EdB) edb+mesa at sigluy.net
Tue Sep 1 00:54:55 PDT 2015


On Tuesday 01 September 2015 17:10:33 Albert Freeman wrote:
> Clang tryed to declare the non type member of struct module (enum type type)
> (in clover/core/module.hpp) instead of a variable of type enum (enum type).
> 
> Signed-off-by: Albert Freeman <albertwdfreeman at gmail.com>

Reviewed by Serge Martin <edb+mesa at sigluy.net>

Can it be pushed to master, and if so, can it also be pushed to 11.0 branch?

   Serge
> ---
>  src/gallium/state_trackers/clover/llvm/invocation.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp
> b/src/gallium/state_trackers/clover/llvm/invocation.cpp index
> 7c23a27..d74b50d 100644
> --- a/src/gallium/state_trackers/clover/llvm/invocation.cpp
> +++ b/src/gallium/state_trackers/clover/llvm/invocation.cpp
> @@ -465,7 +465,7 @@ namespace {
>              const bool is_write_only = access_qual == "write_only";
>              const bool is_read_only = access_qual == "read_only";
> 
> -            typename module::argument::type marg_type;
> +            enum module::argument::type marg_type;
>              if (is_image2d && is_read_only) {
>                 marg_type = module::argument::image2d_rd;
>              } else if (is_image2d && is_write_only) {



More information about the mesa-dev mailing list