[Mesa-dev] [PATCH 1/3] i965: Abort tiled_memcpy path for ReadPixels in case of transfer operations

[Emil Velikov]

Hi all

On 21 August 2015 at 23:04, Anuj Phogat <anuj.phogat at gmail.com> wrote:
> We have a similar check in meta pbo path.
>
> Cc: <mesa-stable at lists.freedesktop.org>
> Signed-off-by: Anuj Phogat <anuj.phogat at gmail.com>
> ---
>  src/mesa/drivers/dri/i965/intel_pixel_read.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/i965/intel_pixel_read.c b/src/mesa/drivers/dri/i965/intel_pixel_read.c
> index 3fe506e..55f6852 100644
> --- a/src/mesa/drivers/dri/i965/intel_pixel_read.c
> +++ b/src/mesa/drivers/dri/i965/intel_pixel_read.c
> @@ -81,6 +81,10 @@ intel_readpixels_tiled_memcpy(struct gl_context * ctx,
>     if (rb == NULL)
>        return false;
>
> +   if (_mesa_get_readpixels_transfer_ops(ctx, rb->Format, format,
> +                                         type, GL_FALSE))
> +      return false;
> +
>     struct intel_renderbuffer *irb = intel_renderbuffer(rb);
>     int dst_pitch;
>
Can we get a pair of eyes looking this way (same goes for the rest of
the series).
They all seem like pretty trivial fixes.

Anuj, can you amend the cc tag before pushing to include 10.6 please.

Thanks
Emil